Replace WWW::Curl::Simple with WWW::Curl::Easy #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Simple` only handles GET and POST requests, unfortunately, so skip it and use `Easy` directly. Add a new method, `_curl`, that creates an `Easy` with everything properly configured, including a custom user agent, basic auth headers, other headers, the request body, and CA validation. It returns the object and references to scalars into which the headers and content will be populated when it executes. Revamp the `t/demo.t` to do basic validation that the method works, then add `t/request.t` to do live testing of its functionality. Have it rely on an environment variable for the base URL it tests against, and load the `go-httpbin` service for local, reliable testing. For whatever reason it returns 100 for requests with a body while httpbingo.org returns 200, so the test accepts either response code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpleonly handles GET and POST requests, unfortunately, so skip it and useEasydirectly. Add a new method,_curl, that creates anEasywith everything properly configured, including a custom user agent, basic auth headers, other headers, the request body, and CA validation. It returns the object and references to scalars into which the headers and content will be populated when it executes.Revamp the
t/demo.tto do basic validation that the method works, then addt/request.tto do live testing of its functionality. Have it rely on an environment variable for the base URL it tests against, and load thego-httpbinservice for local, reliable testing. For whatever reason it returns 100 for requests with a body while httpbingo.org returns 200, so the test accepts either response code.