Add method to open native share sheet from within web-view.#61
Merged
fdocr merged 1 commit intoforem:masterfrom Aug 4, 2020
Merged
Add method to open native share sheet from within web-view.#61fdocr merged 1 commit intoforem:masterfrom
fdocr merged 1 commit intoforem:masterfrom
Conversation
fdocr
reviewed
Jul 27, 2020
fdocr
suggested changes
Jul 27, 2020
Contributor
fdocr
left a comment
fdocr
left a comment
There was a problem hiding this comment.
As mentioned in my last comment from #11 I left a suggestion inline. Thank you again for the contribution @VarunBarad!
VarunBarad
force-pushed
the
feature/native-share-sheet
branch
from
647c9f7 to
b9cd514
Compare
VarunBarad
force-pushed
the
feature/native-share-sheet
branch
from
b9cd514 to
7c63b0b
Compare
Contributor
Author
|
@fdoxyz I have rebased this branch from current Will you be needing anything else now? |
fdocr
approved these changes
Aug 4, 2020
Contributor
fdocr
left a comment
fdocr
left a comment
There was a problem hiding this comment.
This looks great @VarunBarad thank you again for the contribution!
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the native method required to show the Android share sheet when sharing text from the website inside the web-view.
To complete the integration, some code needs to be added to the https://dev.to also. Will create an issue for that over on
thepracticaldev/dev.towith specific instructions as to what changes need to be made.Related Tickets & Documents
Integrating this and its sibling changes in thepracticaldev/dev.to (issue not created yet) will fix #11