Skip to content

Mini refactor to make variable names clearer in the Categories component #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Mini refactor to make variable names clearer in the Categories component #4257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 28 additions & 30 deletions app/javascript/listings/elements/categories.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,54 +3,52 @@ import { h, Component } from 'preact';

class Categories extends Component {
options = () => {
const { categoriesForSelect, category } = this.props
return categoriesForSelect.map(array => {
const { categoriesForSelect, category } = this.props;
return categoriesForSelect.map(([text, value]) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the refactoring here. The rest below line 20 is just prettier kicking in.

// array example: ["Education/Courses (1 Credit)", "education"]
if(category === array[1]) {
return(
<option value={array[1]} selected>{array[0]}</option>
)
if (category === value) {
return (
<option value={value} selected>
{text}
</option>
);
}
return(
<option value={array[1]}>{array[0]}</option>
)
})
}
return <option value={value}>{text}</option>;
});
};

details = () => {
const { categoriesForDetails } = this.props
const { categoriesForDetails } = this.props;
const rules = categoriesForDetails.map(category => {
const paragraphText = `${category.name}: ${category.rules}`
return(
<p>
{paragraphText}
</p>
)
})
const paragraphText = `${category.name}: ${category.rules}`;
return <p>{paragraphText}</p>;
});

return(
return (
<details>
<summary>
Category details/rules
</summary>
<summary>Category details/rules</summary>
{rules}
</details>
)
}
);
};

render() {
const { onChange } = this.props
return(
const { onChange } = this.props;
return (
<div className="field">
<label className="listingform__label" htmlFor="category">
Category
</label>
<select className="listingform__input" name="classified_listing[category]" onChange={onChange} >
<select
className="listingform__input"
name="classified_listing[category]"
onChange={onChange}
>
{this.options()}
</select>
{this.details()}
</div>
)
);
}
}

Expand All @@ -59,6 +57,6 @@ Categories.propTypes = {
categoriesForDetails: PropTypes.array.isRequired,
category: PropTypes.string.isRequired,
onChange: PropTypes.func.isRequired,
}
};

export default Categories;