Feature/medium icon link #901#943
Conversation
|
|
ghost
mentioned this pull request
|
This adds a svg from font awesome for the medium icon. I wasn't sure whether you had a licence for this, so please let me know if works for Dev.to or whether you prefer a different source. The Medium website has a svg file too for its logo, which could be an alternative. |
benhalpern
left a comment
benhalpern
left a comment
There was a problem hiding this comment.
This all looks good to me.
|
@jessleenyc @Zhao-Andy @maestromac if any one of you wants to jump in and give this a second look, go for it. Passes muster to me. |
Zhao-Andy
left a comment
Zhao-Andy
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR!
There was a problem hiding this comment.
LGTM.
One edge case with the regex. Some user are part of an organization and may want to use org profile like (ie https://medium.a-legit-org.org/@maestromac) instead of a normal profile link. That can come later. This is a good MVP 👍
|
@maestromac Totally with you on that last point, at least there is some medium integration now to build on. @Zhao-Andy Cheers for all your patience, and responsive support all along the way with this change. It feels great to contribute to Dev.to - love the site! |
4 participants
What type of PR is this? (check all applicable)
Description
A user can add a Medium url in the settings, which when included would add a link with the Medium icon on profile pages
Related Tickets & Documents
resolves #901
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?