Skip to content

build: enable windows builds #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build: enable windows builds #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

build:
name: ${{ matrix.platform }}
needs: [checks]
needs: [ checks ]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -36,8 +36,8 @@ jobs:
os: macos-14
- platform: macos-x64
os: macos-13
#- platform: windows-x64
# os: windows-2022
- platform: windows-x64
os: windows-2022

steps:
- name: Checkout source code
Expand Down
2 changes: 1 addition & 1 deletion postgresql_commands/src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ impl AsyncCommandExecutor for tokio::process::Command {
// on windows, pg_ctl start will appear to hang if you try to read out all of stdout
// and stderr. so, on windows do a horrible hack and forcibly end reading of stdout
// and stderr 50ms after the process exits. on not-windows, this early exit mechanism
// is set up but never sent to, resulting in the same behavior as `read_to_end`.
// is set up but never sent to, resulting in the same behavior as `read_to_end`.

let (exit_anyway_broadcast_sender, exit_anyway_broadcast_receiver_stdout) =
tokio::sync::broadcast::channel(1);
Expand Down