Skip to content

Add hook CanItemDeployed#146

Closed
rostov114 wants to merge 1 commit into
OxideMod:developfrom
rostov114:patch-1
Closed

Add hook CanItemDeployed#146
rostov114 wants to merge 1 commit into
OxideMod:developfrom
rostov114:patch-1

Conversation

@rostov114
Copy link
Copy Markdown
Contributor

Called before the item is deployed.
(Tested, working)

Called before the item is deployed.
(Tested, working)
@rostov114 rostov114 changed the base branch from develop to oxide April 2, 2019 21:05
@rostov114 rostov114 changed the base branch from oxide to develop April 2, 2019 21:06
@rostov114
Copy link
Copy Markdown
Contributor Author

rostov114 commented Apr 2, 2019

Please, move. Erroneous pull request. Wrong Branch.
Pull request was intended from "oxide" branch.
Sorry.

@lukespragg
Copy link
Copy Markdown
Member

Manually merged, thanks.

@lukespragg lukespragg closed this Apr 25, 2019
@rostov114
Copy link
Copy Markdown
Contributor Author

rostov114 commented Apr 26, 2019

Hello. Is it possible to add entityID as a parameter?
Because when installed in the slot we do not know what BaseEntity he is getting into.

And nevertheless, Deployer may be more correctly transmitted, than Deployable.
Deployer has more information about the environment, including Deployable.

Those. ArgumentString lead to mind:
"ArgumentString": "a0.player, this, l2"

@lukespragg
Copy link
Copy Markdown
Member

Yes, I'll look into adding that.

@rostov114
Copy link
Copy Markdown
Contributor Author

@lukespragg and why you transfer Deployable (l0), but not Deployer (this) second parameter?

@lukespragg
Copy link
Copy Markdown
Member

lukespragg commented May 2, 2019 via email

@rostov114
Copy link
Copy Markdown
Contributor Author

Does Deployable carry Deployer?
It seems the opposite.
Or are there unpublished changes?

@lukespragg
Copy link
Copy Markdown
Member

lukespragg commented May 2, 2019 via email

@rostov114
Copy link
Copy Markdown
Contributor Author

I am based on commit 6b3bbc1 and see the addition of the l2 parameter (entityID).
I'm talking about the second parameter.
Those. now we are passing the parameters "BasePlayer, Deployable, entityID".
I mean to transfer the parameters "BasePlayer, Deployer, entityID".

@lukespragg
Copy link
Copy Markdown
Member

Changed to as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants