Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2023

Bumps isort from 5.11.4 to 5.12.0.

Release notes

Sourced from isort's releases.

5.12.0

Changes

5.11.5 January 30 2023 [hotfix]

  • Fixed incompatiblity with latest poetry version
Changelog

Sourced from isort's changelog.

5.12.0 January 28 2023

  • Removed support for Python 3.7
  • Fixed incompatiblity with latest poetry version
  • Added support for directory limitations within built in git hook

5.11.5 January 30 2023 [hotfix]

  • Fixed incompatiblity with latest poetry version
Commits
  • e44834b Fix changelog / version to a minor bump due to the size of the change
  • 82569d9 Bump version to 5.11.5
  • e00db96 Formatting fix
  • e833931 Merge pull request #2078 from jooola/fix_poetry_validation
  • 0d219a6 fix: poetry pip-shims extras dependency
  • ae0cc1c Merge pull request #1967 from vkomarov-r7/feature/directory-hooks
  • 06d8ef5 Merge pull request #1948 from timgates42/bugfix_typo_determination
  • 0c8a8b8 Merge pull request #2076 from marksmayo/main
  • 5b63fba Clean up
  • a0cb1b8 Fix tmuxp test
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 30, 2023
@coveralls
Copy link

coveralls commented Jan 30, 2023

Pull Request Test Coverage Report for Build 4042667358

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.139%

Totals Coverage Status
Change from base Build 4042482818: 0.0%
Covered Lines: 1345
Relevant Lines: 1362

💛 - Coveralls

@jku
Copy link
Member

jku commented Jan 30, 2023

New isort is not compatible with python 3.7.

Hmm, we list all test requirements in a single requirements file. The failures visible in the CI could be avoided if we had separate test and lint requirements (as we're really only interested in running lint on newest python).

Alternatively: python 3.7 is EOL in 5 months -- we could stop testing with it at that point (and avoid updating isort until then).

@lukpueh
Copy link
Member

lukpueh commented Jan 31, 2023

Hmm, we list all test requirements in a single requirements file. The failures visible in the CI could be avoided if we had separate test and lint requirements (as we're really only interested in running lint on newest python).

Factoring out lint requirements sounds reasonable, regardless of 3.7 lifetime.

Bumps [isort](https://github.com/pycqa/isort) from 5.11.4 to 5.12.0.
- [Release notes](https://github.com/pycqa/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@5.11.4...5.12.0)

---
updated-dependencies:
- dependency-name: isort
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from c0855d1 to 9c10025 Compare February 2, 2023 10:52
@jku jku mentioned this pull request Feb 2, 2023
@jku
Copy link
Member

jku commented Feb 3, 2023

closing for #2289

@jku jku closed this Feb 3, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 3, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/isort-5.12.0 branch February 3, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants