Skip to content

Conversation

sumanth8495
Copy link
Contributor

Fixes #2439

Description of the changes being introduced by the pull request:

  • Includes version comments in GH action uses-lines

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: sumanth8495 <msgupthamurukuri123@gmail.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number in my example was meant as an example, not as the value that every action should have.

So when you did this:

actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v2.3.4

I was expecting to see the version number for actions/checkout that matches f43a0e5. This is visible in e.g. https://github.com/actions/checkout/releases/: v3.6.0

theupdateframework/specification/.github/workflows/check-latest-spec-version.yml@master is a special case that I should have mentioned: no need to comment that one with a release

Signed-off-by: sumanth8495 <msgupthamurukuri123@gmail.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks pretty good. Looks like you figured out the codeql versioning which always baffles me...

I found two potential bugs and a couple of missing version comments -- I'd like at least the bugs to be fixed before merging.

Signed-off-by: sumanth8495 <msgupthamurukuri123@gmail.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your persistence!

@jku jku merged commit b84434a into theupdateframework:develop Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include version comments in GH action uses-lines

2 participants