Skip to content

Conversation

@Ryzee119
Copy link
Contributor

Attempted to use in Arduino, but got linker errors.
This resolved the issue.

Attempted to use in Arduino, but got linker errors.
This resolved the issue.
@Ryzee119 Ryzee119 closed this Sep 17, 2020
@postspectacular
Copy link
Member

Thanks, @Ryzee119! 🙏 (this was on my todo list, but personally not using C++...)

@postspectacular
Copy link
Member

May I also ask why you've closed the PR?

@Ryzee119
Copy link
Contributor Author

Ryzee119 commented Sep 17, 2020

I realised i could encompass the include with extern c, without modifying your file. 😊
But will reopen for your review as this makes it an even easier addition to CPP projects.

@Ryzee119 Ryzee119 reopened this Sep 17, 2020
@postspectacular postspectacular merged commit 7273051 into thi-ng:master Sep 18, 2020
@postspectacular
Copy link
Member

Thanks again & that's great!! 🎉

@Ryzee119 Ryzee119 deleted the patch-1 branch September 18, 2020 00:41
@Ryzee119
Copy link
Contributor Author

No problem 👍 , been using this for a few days now. Works great! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants