Skip to content

Commit e85f0c5

Browse files
committed
fix(config): remove option that does not serialise as JSON
1 parent 41cd298 commit e85f0c5

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

src/__snapshots__/semver.test.js.snap

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ Object {
2222
"id-length": Array [
2323
0,
2424
],
25-
"import/no-cycle": Array [
26-
2,
27-
],
2825
"import/no-extraneous-dependencies": Array [
2926
2,
3027
Object {

src/base.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ module.exports = {
4646
// Does not work at the moment for nested fields.
4747
// https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
4848
"jsx-a11y/label-has-for": [0],
49-
// Override airbnb config to make it serialisable to JSON.
50-
// https://github.com/airbnb/javascript/blob/32a7bf44c2e5b3d2a5d05af46716fbe45bc09bec/packages/eslint-config-airbnb-base/rules/imports.js#L230
51-
"import/no-cycle": [2],
5249
},
5350

5451
// http://eslint.org/docs/user-guide/configuring#specifying-environments

src/config.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ const getComputedConfig = (baseConfig) => {
1515
delete config.filePath;
1616
delete config.baseDirectory;
1717

18+
// Remove option that does not serialise well to JSON.
19+
config.rules["import/no-cycle"] = config.rules["import/no-cycle"][0];
20+
1821
return config;
1922
};
2023

0 commit comments

Comments
 (0)