Converting 3.0 -> 3.1: `nullable` not converted in `anyOf` or `oneOf`

[sam-super]

E.g.

foo:
  oneOf:
    - title: bar
      $ref: '#/components/schemas/Bar'
    - title: baz
      $ref: '#/components/schemas/Baz'
  nullable: true

I think should covert to:

foo:
  oneOf:
    - title: bar
      $ref: '#/components/schemas/Bar'
    - title: baz
      $ref: '#/components/schemas/Baz'
    - type: 'null'

I can see from convertNullable it's looking for the type prop and doesn't look at oneOf or anyOf.

I will get a PR together but please let me know if i'm making an incorrect assumption above.

[thim81]

hi @sam-super

That is a good catch.
I would have to double check the OpenAPI v3.1 specification, but nullable is replaced by "type: 'null'

Happy to see your PR coming in and review it 🤝 .

[sam-super]

Hi @thim81, thanks for your fast response!
Here is the PR:
#173
Happy to make any changes you want (or for you to make them if you would rather).
👍

[thim81]

Thanks @sam-super, great to have you reporting and contributing.
Your PR fixed the issue for the 3.1 conversion, and some more.

We just release openapi-format v1.27.3 which contains your PR that handles the anyOf or oneOf conversion to OpenAPI 3.1.

Thanks again for taking the time to contribute, much appreciated.