Skip to content

qwen_instruct and search_env recipe fixes #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
+12 −5
Merged

qwen_instruct and search_env recipe fixes #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tinker_cookbook/recipes/tool_use/search/search_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

SEARCH_TOOL_SYSTEM_PROMPT = """
You are an expert assistant who solves tasks using a Wikipedia search tool.
Tool calling. Execute the tool by wrapping calls in <function_call>...</function_call>
Tool calling. Execute the tool by wrapping calls in <tool_call>...</tool_call>

The search tool you are given has the following schema:
```
Expand Down Expand Up @@ -69,9 +69,9 @@
“Between 2020 and 2025, which year did New York City see the most population growth and how did San Francisco population change in that year?”

1. Think step by step: In order to answer this question, I need to know the population of New York City and San Francisco between 2020 and 2025. I will search for the population of New York City in each year
2. Calling search tool: <function_call>{"name": "search", "args": {"query_list": ["Population New York city between 2020 and 2025"]}}</function_call> (Output omitted for brevity)
2. Calling search tool: <tool_call>{"name": "search", "args": {"query_list": ["Population New York city between 2020 and 2025"]}}</tool_call> (Output omitted for brevity)
3. Think step by step again: I have the population of New York City in each year, and I see that the population of New York City grew the most in 2024. I need to know the population of San Francisco in 2024. I will search for the population of San Francisco in each year.
<function_call>{"name": "search", "args": {"query_list": ["Population San Francisco between 2023 and 2024"]}}</function_call> (Output omitted for brevity)
<tool_call>{"name": "search", "args": {"query_list": ["Population San Francisco between 2023 and 2024"]}}</tool_call> (Output omitted for brevity)
4. Answer: The population of New York City grew the most in 2024, and the population of San Francisco changed by XXXX in 2024.
"""

Expand Down
11 changes: 9 additions & 2 deletions tinker_cookbook/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,13 +481,20 @@ def _render_message(self, idx: int, message: Message) -> tuple[list[int], list[i
ob_str = f"{maybe_newline}<|im_start|>{message['role']}\n"
ac_content = message["content"]
# Observation (prompt) part
ac_str = f"{ac_content}<|im_end|>"
if "tool_calls" in message:
ac_content += "\n".join(
[
f"<tool_call>\n{json.dumps(tool_call)}\n</tool_call>"
for tool_call in message["tool_calls"]
]
)
ac_content += "<|im_end|>"
# Action part
ac_tail_str = "" # No action tail needed for Qwen format
# Action part that's only included in the last message in SFT
return (
self.tokenizer.encode(ob_str, add_special_tokens=False),
self.tokenizer.encode(ac_str, add_special_tokens=False),
self.tokenizer.encode(ac_content, add_special_tokens=False),
self.tokenizer.encode(ac_tail_str, add_special_tokens=False),
)

Expand Down