Skip to content

Conversation

@arjungupta01
Copy link
Contributor

Added Stone Paper Scissor Game please review and merge my pull request!!
Thankyou

@thinkswell
Copy link
Owner

Hi @arjungupta01
Please update the directory name, and follow the guidelines in the readme file.
Thank you.

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arjungupta01 , your repository requires some changes before it can be merged:


❌ RENAMING: You should considering adding your project in the pre-existing RockPaperScissorsGame folder and not StonePaperScissors game folder.


❌ ADDING: And consider adding Live Link or Screenshot of your project with the README file or in the description of this PR. This helps us review your project for compliance.


❌ DIRECTORY: Your project files, including the README.md should be inside another folder called arjungupta01, so ideally your pull request changes would look something like this: 

javascript-mini-projects
|           
-------- RockPaperScissorsGame
           |
            ----- arjungupta01
                   |
                    -------- **Your project files and folders**
                   |
                    --------- README.md (optional yet preferred)

❓ REFERENCES:

  1. Refer to How to raise the PR for more information

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 8, 2023
@arjungupta01 arjungupta01 requested a review from PBJI October 10, 2023 18:33
@arjungupta01
Copy link
Contributor Author

Hey @PBJI sir i have made changes as you said !!

@PBJI PBJI merged commit 3119687 into thinkswell:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants