fix: fixes the issue #609 #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@PBJI it fixes the issue #609 which will close this issue |
Closed
PBJI
approved these changes
Oct 8, 2023
Collaborator
PBJI
left a comment
PBJI
left a comment
There was a problem hiding this comment.
Nice work, although @rituraj12797 I would suggest you to use seperate files for keep your css and javascript instead of using the html page as the store house for all of it. Mergin this PR, as it is compliant witht the repo contribution guidelines.
Thank you.
Contributor
Author
|
thank you @PBJI , will keep this in mind from next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
Summary
Added the weather app project
Screenshot
Live Project Link
https://rituraj12797.github.io/weatherApp/