Made all the changes as per the readme guidelines #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBJI
approved these changes
Oct 8, 2023
Collaborator
There was a problem hiding this comment.
Hi @Abhay-Gupta008
✔️ APPROVED: This project is compliant with the contribution guidelines, hence it is approved to be merged with javascript-mini-project.
Although, not strict but conventionally:
ADDING: And consider adding README.md with
- Summary about your project
- How to setup and use
- Add the screenshots in it.
Thank you. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
Summary
I have made a project with three.js which includes floating Islands.
Screenshot
Live Project Link
add a working project link here