Skip to content

Conversation

@tedante
Copy link
Contributor

@tedante tedante commented Oct 8, 2023

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

add generate random number to the repo

Screenshot

image

Live Project Link

no link

please kindly to reviewing my pull request
thank you

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tedante , your repository requires some changes before it can be merged:


❌ RENAMING: You should considering renaming your root folder into RandomNumber folder from randomNumber folder.


😅 ADDING (Optional): And consider adding README.md with 

  1. Summary about your project
  2. How to setup and use 
  3. Add the screenshots in it.

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 8, 2023
@tedante
Copy link
Contributor Author

tedante commented Oct 8, 2023

Hi @PBJI , sorry my bad

I just update the code
[x] rename folder
[x] add readme
[x] add screenshots

Please review my new code
Thank you

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good @tedante

@PBJI PBJI merged commit 45f99ed into thinkswell:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants