Skip to content

Conversation

@aditya7302
Copy link
Contributor

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)
  • Digital Clock #697

Summary

add a summary here

Screenshot

attach screenshots/gifs here

Live Project Link

add a working project link here

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Username, your repository requires some changes before it can be merged:


❌ RENAMING: You should considering adding your project in the pre-existing Clock folder and not digital_clock folder.


❌ ADDING: And consider adding Live Link or Screenshot of your project with the README file or in the description of this PR. This helps us review your project for compliance.


❌ DIRECTORY: Your project files, including the README.md should be inside another folder called aditya7302, so ideally your pull request changes would look something like this:

javascript-mini-projects
|           
-------- Clock
           |
            ----- aditya7302 
                   |
                    -------- **Your project files and folders**
                   |
                    --------- README.md (optional yet preferred)

😅 ADDING (Optional): And consider adding README.md with 

  1. Summary about your project
  2. How to setup and use 
  3. Add the screenshots in it.

❓ REFERENCES:

  1. Refer to How to raise the PR for more information

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aditya7302


✔️ APPROVED: This project is compliant with the contribution guidelines, hence it is approved to be merged with javascript-mini-project.


Thank you. 😄

@PBJI PBJI merged commit ed62fa3 into thinkswell:master Oct 8, 2023
@aditya7302
Copy link
Contributor Author

aditya7302 commented Oct 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants