Skip to content

Conversation

@Yasir761
Copy link
Contributor

@Yasir761 Yasir761 commented Oct 8, 2023

Summary

Made a Novelty Age Calculator In HTML, CSS, Vanilla JavaScript.

Solves : Issue #701
Closes : Issue #701

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yasir761 , your repository requires some changes before it can be merged:


❌ RENAMING: You should considering adding your project in the pre-existing NoveltyCalculator folder and not Novelty_Age_Calculator folder.


❌ ADDING: And consider adding Live Link or Screenshot of your project with the README file or in the description of this PR. This helps us review your project for compliance.


❌ DIRECTORY: Your project files, including the README.md should be inside another folder called Yasir761, so ideally your pull request changes would look something like this:

javascript-mini-projects
|           
-------- NoveltyCalculator
           |
            ----- Yasir761 
                   |
                    -------- **Your project files and folders**
                   |
                    --------- README.md (optional yet preferred)

😅 ADDING (Optional): And consider adding/updating README.md with 

  1. Summary about your project
  2. How to setup and use 
  3. Add the screenshots in it.

❓ REFERENCES:

  1. Refer to How to raise the PR for more information

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 8, 2023
@Yasir761
Copy link
Contributor Author

Yasir761 commented Oct 8, 2023

@PBJI, please review

@PBJI PBJI merged commit 59812a4 into thinkswell:master Oct 8, 2023
@Yasir761 Yasir761 deleted the Add-a-novelty-calculator branch October 10, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants