Skip to content

Conversation

@Shivam250702
Copy link
Contributor

@Shivam250702 Shivam250702 commented Oct 8, 2023

This is a simple Background Generator made Using Html,CSS and JS.

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

add a summary here

Simple HTML CSS and JS file made to Generate Background

Screenshot

attach screenshots/gifs here

image

Live Project Link

add a working project link here

This is a simple Background Generator made Using Html,CSS and JS.
Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shivam250702 , your repository requires some changes before it can be merged:


❌ RENAMING: You should considering renaming your root folder into BackgroundGenerator from folder BACKGROUND_GENERATOR folder.


❌ DIRECTORY: Your project files, including the README.md should be inside another folder called Shivam250702, so ideally your pull request changes would look something like this:

javascript-mini-projects
|           
-------- BackgroundGenerator
           |
            ----- Shivam250702
                   |
                    -------- **Your project files and folders**
                   |
                    --------- README.md (optional yet preferred)

😅 ADDING (Optional): And consider adding/updating README.md with 

  1. Summary about your project
  2. How to setup and use 
  3. Add the screenshots in it.

❓ REFERENCES:

  1. Refer to How to raise the PR for more information

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to directory to BackgroundGenerator/Shivam250702

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 9, 2023
@Shivam250702
Copy link
Contributor Author

Sir,
I have made the necessary changes please check

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shivam250702 You just cloned javascript-mini-projects inside your cloned javascript-mini-projects delete that sub-module and I'll review for merge.

Delete javascript-mini-projects/javascript-mini-projects

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have perhaps unintentionally added the main "javascript-mini-project" inside your forked repo, look in the review section.

@Shivam250702
Copy link
Contributor Author

Sir,
I have done the required changes as mentioned by you please check.

@PBJI PBJI merged commit d2a2989 into thinkswell:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants