-
Notifications
You must be signed in to change notification settings - Fork 947
BackgroundGenerator/Shivam250702 #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a simple Background Generator made Using Html,CSS and JS.
PBJI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shivam250702 , your repository requires some changes before it can be merged:
❌ RENAMING: You should considering renaming your root folder into BackgroundGenerator from folder BACKGROUND_GENERATOR folder.
❌ DIRECTORY: Your project files, including the README.md should be inside another folder called Shivam250702, so ideally your pull request changes would look something like this:
javascript-mini-projects
|
-------- BackgroundGenerator
|
----- Shivam250702
|
-------- **Your project files and folders**
|
--------- README.md (optional yet preferred)
😅 ADDING (Optional): And consider adding/updating README.md with
- Summary about your project
- How to setup and use
- Add the screenshots in it.
❓ REFERENCES:
- Refer to How to raise the PR for more information
Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.
Thank you. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to directory to BackgroundGenerator/Shivam250702
|
Sir, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shivam250702 You just cloned javascript-mini-projects inside your cloned javascript-mini-projects delete that sub-module and I'll review for merge.
Delete javascript-mini-projects/javascript-mini-projects
javascript-mini-projects
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have perhaps unintentionally added the main "javascript-mini-project" inside your forked repo, look in the review section.
|
Sir, |
This is a simple Background Generator made Using Html,CSS and JS.
Developer Checklist
Summary
add a summary here
Simple HTML CSS and JS file made to Generate Background
Screenshot
attach screenshots/gifs here
Live Project Link
add a working project link here