Skip to content

Conversation

@vinay-s36
Copy link
Contributor

Developer Checklist

  • [✅] Followed guidelines mentioned in the readme file.
  • [✅] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • [✅] Starred ⭐ the Repo (Optional)

Summary

Guess It - The Random Number Guesser project in JavaScript is an interactive web application that challenges users to guess a randomly generated number within a specified range. It provides an engaging way to learn and practice JavaScript programming while creating a fun user experience.

Screenshot

image

image

image

Live Project Link

https://vinay-s36.github.io/Guess-It/

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vinay-s36 , your repository requires some changes before it can be merged:


❌ RENAMING: You should considering adding your project in the pre-existing NumberGuessingGame folder and not Guess It folder.


❌ DIRECTORY: Your project files, including the README.md should be inside another folder called vinay-s36, so ideally your pull request changes would look something like this:

javascript-mini-projects
|           
-------- NumberGuessingGame
           |
            ----- vinay-s36
                   |
                    -------- **Your project files and folders**
                   |
                    --------- README.md (optional yet preferred)

😅 ADDING (Optional): And consider adding/updating README.md with 

  1. Summary about your project
  2. How to setup and use 
  3. Add the screenshots in it.

❓ REFERENCES:

  1. Refer to How to raise the PR for more information

Once you make these necessary changes, please revert back with a comment mentioning @PBJI so that I get notified.

Thank you. 😄

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 8, 2023
@vinay-s36
Copy link
Contributor Author

@PBJI i have made all the necessary changes i was told

added files in the same structure i was asked and added READme.md with instructions of how to run the project with screenshots of the peoject

Let me know if there are any changes required

@PBJI PBJI merged commit 5181493 into thinkswell:master Oct 8, 2023
@vinay-s36 vinay-s36 deleted the vinay-s36-guessit branch October 9, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changeRequested The requested changes should be adhered to before further review or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants