-
Notifications
You must be signed in to change notification settings - Fork 947
Ping pong #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ping pong #763
Conversation
|
@PBJI Have a look |
PBJI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayan-joshi change name from Ping Pong to PingPong/ayan-joshi
okay. |
1 similar comment
okay. |
|
@PBJI did the change u asked |
|
cannot add @ayan-joshi, delete Sort Visualizer from the above commit and please add PingPong/AyanJoshi as the directory name. Thank you |
got it @PBJI , and did the changes |
|
also delete the Sorting Visualizer directory that you accidentally left from your last commit in your fork. |
|
@PBJI donee lesgo |
|
I am sorry just one issue change it to PingPongGame instead as their already exist a directory by that name. And I'll merge it. Thank you |
|
@PBJI please merge its approved by @NitkarshChourasia |
I just review codes. @ayan-joshi |
Do this. |
NitkarshChourasia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PBJI is asking to change it to PingPong to PingPongGame, the root directory.
Can you take care of it?!
@ayan-joshi ?
|
@PBJI @NitkarshChourasia made the changes please merge it |
|
I just review them, merges are made by @PBJI
…On Wed 11 Oct, 2023, 10:40 PM Ayan Joshi, ***@***.***> wrote:
@PBJI <https://github.com/PBJI> @NitkarshChourasia
<https://github.com/NitkarshChourasia> made the changes please merge it
—
Reply to this email directly, view it on GitHub
<#763 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVTTXYHIUYIKYNIBW3JH3ATX63HJBANCNFSM6AAAAAA5X5XCKU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
NitkarshChourasia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! @PBJI See to it.
|
Good Night.
…On Thu, 12 Oct 2023 at 02:46, Purshotam Bohra ***@***.***> wrote:
Merged #763
<#763> into
master.
—
Reply to this email directly, view it on GitHub
<#763 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVTTXYGFIHQTV3HG2TQL4X3X64ED3ANCNFSM6AAAAAA5X5XCKU>
.
You are receiving this because you were mentioned.Message ID:
<thinkswell/javascript-mini-projects/pull/763/issue_event/10624328917@
github.com>
--
Nitkarsh Chourasia
|
Developer Checklist
Summary
As mentioned in the issue #748 , I added the ping pong multiplayer game in the repo please have a look and merge my pull request @PBJI