Skip to content

Conversation

@ayan-joshi
Copy link
Contributor

@ayan-joshi ayan-joshi commented Oct 8, 2023

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

As mentioned in the issue #748 , I added the ping pong multiplayer game in the repo please have a look and merge my pull request @PBJI

@ayan-joshi
Copy link
Contributor Author

@PBJI Have a look

Copy link
Collaborator

@PBJI PBJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayan-joshi change name from Ping Pong to PingPong/ayan-joshi

@NitkarshChourasia
Copy link
Collaborator

@ayan-joshi change name from Ping Pong to PingPong/ayan-joshi

okay.

1 similar comment
@NitkarshChourasia
Copy link
Collaborator

@ayan-joshi change name from Ping Pong to PingPong/ayan-joshi

okay.

@ayan-joshi
Copy link
Contributor Author

@PBJI did the change u asked

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

cannot add @ayan-joshi, delete Sort Visualizer from the above commit and please add PingPong/AyanJoshi as the directory name. Thank you

@ayan-joshi
Copy link
Contributor Author

cannot add @ayan-joshi, delete Sort Visualizer from the above commit and please add PingPong/AyanJoshi as the directory name. Thank you

got it @PBJI , and did the changes

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

also delete the Sorting Visualizer directory that you accidentally left from your last commit in your fork.

@ayan-joshi
Copy link
Contributor Author

@PBJI donee lesgo

@PBJI
Copy link
Collaborator

PBJI commented Oct 9, 2023

I am sorry just one issue change it to PingPongGame instead as their already exist a directory by that name. And I'll merge it.

Thank you
Purshotam Bohra

@ayan-joshi
Copy link
Contributor Author

@PBJI please merge its approved by @NitkarshChourasia

@NitkarshChourasia
Copy link
Collaborator

@PBJI please merge its approved by @NitkarshChourasia

I just review codes.
Merging standards, are being managed by @PBJI.
He takes care that it follows repository standards, as mentioned on README.md

@ayan-joshi
Thank you.
@NitkarshChourasia

@NitkarshChourasia
Copy link
Collaborator

@PBJI please merge its approved by @NitkarshChourasia

I am sorry just one issue change it to PingPongGame instead as their already exist a directory by that name. And I'll merge it.

Thank you Purshotam Bohra

Do this.

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PBJI is asking to change it to PingPong to PingPongGame, the root directory.
Can you take care of it?!
@ayan-joshi ?

@ayan-joshi
Copy link
Contributor Author

@PBJI @NitkarshChourasia made the changes please merge it

@NitkarshChourasia
Copy link
Collaborator

NitkarshChourasia commented Oct 11, 2023 via email

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! @PBJI See to it.

@PBJI PBJI merged commit b288ec6 into thinkswell:master Oct 11, 2023
@NitkarshChourasia
Copy link
Collaborator

NitkarshChourasia commented Oct 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants