success update main readme and tell to contribute on our hosting frontend part #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@PBJI updated the as you say readme for knowing the users about the creating the frontend for showcasing all the projects |
NitkarshChourasia
previously requested changes
Oct 14, 2023
|
|
||
| # Creating the Frontend to showcase all the projects | ||
|
|
||
| Hey, Contributor we created the 1Application-frontend folder in top of repo where all the projects will render there and it will host my the maintainer all the contributor which is contributing to this project should contribute to 1Application-frontend also and make that dream successfully to host all the project in one Frontend. |
Collaborator
There was a problem hiding this comment.
Typos are there. Sentence formation is not good.
Contributor
Author
There was a problem hiding this comment.
what fomating you required tell me
| npm run dev | ||
| ``` | ||
|
|
||
| <h3 align="left">Languages and Tools:</h3> |
Collaborator
There was a problem hiding this comment.
not necessary still...if wanted.
Contributor
Author
There was a problem hiding this comment.
It is good to tell the user what tech we are working on.
Contributor
Author
|
From my side I have done it as @NitkarshChourasia said some changes he can make changes of it you can merge it now and then @NitkarshChourasia will changed what he want |
PBJI
approved these changes
Oct 14, 2023
PBJI
dismissed
NitkarshChourasia’s stale review
Will resolve this issue with next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
Summary
add a summary here
Screenshot
attach screenshots/gifs here
Live Project Link
add a working project link here