This repository was archived by the owner on Jan 5, 2022. It is now read-only.
Update build script, peerDeps, and README #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2020
third774
approved these changes
Sep 30, 2020
| node_js: | ||
| - 10.16.3 | ||
| script: ng build --project ng-bootstrap-form-validation | ||
| script: ng build --prod --project ng-bootstrap-form-validation |
There was a problem hiding this comment.
Hrm, should we update the build script in package.json instead?
There was a problem hiding this comment.
Wouldn't be a bad idea
There was a problem hiding this comment.
I misread this, I already updated it in the previous MR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't realize that Travis wasn't using the
buildscript from thepackage.json, also updated thereadme.mdto note the new version (v9 tracking the ng version).Also, I'll be pushing a v10 (which will track ng 10) probably later today but I wanted to have a release for v9.