This repository was archived by the owner on Jan 5, 2022. It is now read-only.
Fix message not showing for deeply nested control #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix showing the error message not showing in case form-control is deeply nested like this <div class="form-group"><div><input class="form-control"/></div></div>
|
This Pull request will solve this issue #95 |
giriprashaad
approved these changes
Nov 23, 2020
|
@giriprashaad I'll review very soon. Thanks for the PR! |
sambernet
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
I'm in no way a contributor or committer on this project, but as we are also affected by the issue, I might as well jump in and contribute my thoughts on this here 😉 So there we go:
- The change makes sense technically and semantically. There's not much to add here.
- Only thing that could potentially be improved is to add a test case that verifies the (changed) behavior.
Looking at the existing tests it looks like the spec is just the plain file resulting from ng g c, so that is probably not really required here... 😇
third774
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix showing the error message not showing in case form-control is deeply nested like this
this happened after upgrading to Angular 9, disabling Ivey Compiler on the Application level somehow solves the problem