Skip to content

Make CreateSessionKey parameters optional with defaults #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
+12 −12
Merged

Make CreateSessionKey parameters optional with defaults #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Thirdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,12 @@ public async Task<List<SignerPermissions>> GetAllActiveSigners()
/// <param name="reqValidityEndTimestamp">The timestamp when the request validity ends. Make use of our Utils to get UNIX timestamps.</param>
public async Task<ThirdwebTransactionReceipt> CreateSessionKey(
string signerAddress,
List<string> approvedTargets,
string nativeTokenLimitPerTransactionInWei,
string permissionStartTimestamp,
string permissionEndTimestamp,
string reqValidityStartTimestamp,
string reqValidityEndTimestamp
List<string> approvedTargets = null,
string nativeTokenLimitPerTransactionInWei = null,
string permissionStartTimestamp = null,
string permissionEndTimestamp = null,
string reqValidityStartTimestamp = null,
string reqValidityEndTimestamp = null
)
{
if (await Utils.IsZkSync(this.Client, this.ActiveChainId).ConfigureAwait(false))
Expand All @@ -419,12 +419,12 @@ string reqValidityEndTimestamp
{
Signer = signerAddress,
IsAdmin = 0,
ApprovedTargets = approvedTargets,
NativeTokenLimitPerTransaction = BigInteger.Parse(nativeTokenLimitPerTransactionInWei),
PermissionStartTimestamp = BigInteger.Parse(permissionStartTimestamp),
PermissionEndTimestamp = BigInteger.Parse(permissionEndTimestamp),
ReqValidityStartTimestamp = BigInteger.Parse(reqValidityStartTimestamp),
ReqValidityEndTimestamp = BigInteger.Parse(reqValidityEndTimestamp),
ApprovedTargets = approvedTargets ?? new List<string> { Constants.ADDRESS_ZERO },
NativeTokenLimitPerTransaction = BigInteger.Parse(nativeTokenLimitPerTransactionInWei ?? "0"),
PermissionStartTimestamp = BigInteger.Parse(permissionStartTimestamp ?? "0"),
PermissionEndTimestamp = BigInteger.Parse(permissionEndTimestamp ?? Utils.GetUnixTimeStampIn10Years().ToString()),
ReqValidityStartTimestamp = BigInteger.Parse(reqValidityStartTimestamp ?? "0"),
ReqValidityEndTimestamp = BigInteger.Parse(reqValidityEndTimestamp ?? Utils.GetUnixTimeStampIn10Years().ToString()),
Uid = Guid.NewGuid().ToByteArray(),
};

Expand Down
Loading