Skip to content

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Sep 27, 2025

Summary by CodeRabbit

  • New Features
    • Introduced adaptive concurrency based on the connected network, enabling higher parallel transaction handling where supported.
    • Specifically boosts parallelism on a designated network to improve throughput, while keeping behavior unchanged for single-account setups.

Copy link

coderabbitai bot commented Sep 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds extraction of chain_id during EoaExecutorWorker initialization and modifies max_inflight calculation: for non-minimal accounts, if chain_id is 1628, max_inflight is set to 20; otherwise, it uses the configured self.max_inflight. Minimal accounts keep existing behavior.

Changes

Cohort / File(s) Summary of Changes
EOA Executor Worker init logic
executors/src/eoa/worker/mod.rs
Introduced local chain_id = chain.chain_id() and adjusted max_inflight selection: unchanged for minimal accounts; for others, special-case chain_id == 1628 to max_inflight = 20, else use self.max_inflight.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Chain
  participant W as EoaExecutorWorker::new
  participant Cfg as Self (config)

  rect rgba(232, 244, 253, 0.5)
  W->>C: chain_id()
  C-->>W: chain_id
  end

  alt minimal accounts
    Note over W: max_inflight = existing minimal-accounts logic
  else non-minimal accounts
    alt chain_id == 1628
      Note over W: max_inflight = 20
    else other chains
      W->>Cfg: read self.max_inflight
      Cfg-->>W: value
      Note over W: max_inflight = self.max_inflight
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pb/lower-max-inflight-1628

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 404dfe1 and 5363def.

📒 Files selected for processing (1)
  • executors/src/eoa/worker/mod.rs (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@d4mr d4mr merged commit 3683591 into main Sep 27, 2025
2 of 3 checks passed
@d4mr d4mr deleted the pb/lower-max-inflight-1628 branch September 27, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant