log error and re-add noop flow

[d4mr]

Summary by CodeRabbit

• New Features

  • Outcome-specific logging during transaction submission (success, nack, fail) for clearer diagnostics and easier troubleshooting.

• Bug Fixes

  • More resilient handling of stalled transactions: automatically attempts a safe no-op to unblock a stuck nonce before considering manual reset, reducing interruptions and improving reliability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updates confirm flow to attempt a no-op transaction when a gas bump for a stalled nonce fails, processing it if sent; otherwise schedules a manual reset. Send flow now constructs a submission result, matches on its type (Success/Nack/Fail) for targeted logging, then continues with uniform processing. Some imports/public types are surfaced.

Changes

Cohort / File(s)	Summary
Confirm fallback control flow executors/src/eoa/worker/confirm.rs	Replaces auto-reset on gas bump failure with a no-op transaction attempt for the stalled nonce. If no-op send succeeds, processes via store; logs but continues on processing error. If no-op send fails, logs and schedules manual reset. Updated logs reflect the no-op fallback path.
Send flow result handling and logging executors/src/eoa/worker/send.rs	Expands imports (incl. Transaction, EoaExecutorStore, EoaExecutorWorker, SubmissionResultType). Constructs a local SubmissionResult, matches on its type to emit per-variant logs (Success/Nack/Fail), then proceeds to batch processing. No change to outcome semantics; standardized inspection/logging path.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant W as EOA Worker (confirm)
  participant N as Network
  participant S as Store

  rect rgba(230,240,255,0.5)
    note over W: Gas bump attempt for stalled nonce
    W->>N: Try gas bump
    alt Bump succeeds
      W->>S: Proceed as normal
    else Bump fails
      note over W: New fallback
      W->>N: Send no-op tx for stalled nonce
      alt No-op sent
        W->>S: Process no-op via store
        alt Store processing fails
          W->>W: Log processing error (no-op path succeeded)
        else Store processing ok
          W->>W: Log no-op processed
        end
      else No-op send fails
        W->>W: Log no-op send error
        W->>W: Schedule manual reset
      end
    end
  end

Loading

sequenceDiagram
  autonumber
  participant W as EOA Worker (send)
  participant N as Network
  participant S as Store

  W->>N: Submit transaction
  N-->>W: SubmissionResult
  rect rgba(240,255,240,0.5)
    W->>W: Match SubmissionResultType
    alt Success
      W->>W: Log success
    else Nack
      W->>W: Log NACK
    else Fail
      W->>W: Log failure
    end
  end
  W->>S: Batch/process submission result (uniform path)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pb/log-error-and-noop

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3683591 and 31c7c1a.

📒 Files selected for processing (2)

• executors/src/eoa/worker/confirm.rs (1 hunks)
• executors/src/eoa/worker/send.rs (2 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}