Refactor transaction failure handling to use direct Redis pipeline

[joaquim-verges]

Summary by CodeRabbit

• Refactor
  • Optimized internal transaction handling workflow for improved system reliability and performance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors failure handling in an atomic operation by replacing an inlined, lock-guarded closure with an explicit Redis pipeline workflow. The pipeline performs the same sequence: removes pending entry, updates data with failure info, and queues webhook envelope notifications when applicable.

Changes

Cohort / File(s)	Summary
Redis Pipeline Refactoring executors/src/eoa/store/atomic.rs	Replaces inline closure-based operation inside with_lock_check with explicit atomic Redis pipeline. Updates webhook context construction to use pipeline reference, executes via pipeline.query_async(), and adds trace logging with transaction metadata after execution. Error handling remains consistent, logging webhook queue failures without propagation.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Old as with_lock_check<br/>(inline closure)
    participant New as Explicit Pipeline
    participant Redis
    
    rect rgb(200, 220, 255)
    Note over Caller,New: Old Flow: Closure-based
    Caller->>Old: invoke operation
    Old->>Old: construct closure
    Old->>Redis: execute: remove pending<br/>update data + failure<br/>queue webhook
    Redis-->>Old: result
    end
    
    rect rgb(220, 255, 220)
    Note over Caller,New: New Flow: Explicit Pipeline
    Caller->>New: invoke operation
    New->>New: create atomic pipeline
    New->>New: pipeline.remove(...)<br/>pipeline.update(...)<br/>pipeline.queue_webhook(...)
    New->>Redis: pipeline.query_async()
    Redis-->>New: result
    New->>New: log trace with context<br/>return Ok(())
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Focus areas:
  • Verify the pipeline operations maintain functional equivalence with the original inline closure logic
  • Confirm webhook context construction using transaction_context_from_pipeline(&mut pipeline) is correct
  • Review that error handling for webhook queueing failures remains non-propagating
  • Ensure all transaction metadata (transaction_id, EOA, chain_id, error details) is correctly captured in the final trace log

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Refactor_transaction_failure_handling_to_use_direct_Redis_pipeline

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f1ea797 and 2ea7164.

📒 Files selected for processing (1)

• executors/src/eoa/store/atomic.rs (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[joaquim-verges]

• Refactor transaction failure handling to use direct Redis pipeline #89 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.