Revert "improve abi parsing (#213)"

[iuwqyir]

Simplify ABI Parsing Logic

Refactors the contract ABI fetching logic in GetABIForContract by:

• Removing the unnecessary step of reading the entire response body into memory
• Parsing the ABI directly from the response body stream
• Eliminating the JSON decode mutex that's no longer needed
• Removing unused imports (io and log)

This change makes the code more efficient by avoiding an extra memory allocation and simplifying the error handling path.

Summary by CodeRabbit

• Refactor
  • Improved the process for retrieving and parsing contract ABIs, resulting in a more efficient and streamlined experience when interacting with contract data.

[coderabbitai]

Walkthrough

The code refactors the GetABIForContract function by removing the use of a mutex and intermediate byte slice for JSON decoding, simplifying error handling, and directly parsing the ABI from the HTTP response body stream. Unused imports and the jsonDecodeMutex variable were also removed.

Changes

File(s)	Change Summary
internal/common/abi.go	Removed unused imports, deleted jsonDecodeMutex, refactored GetABIForContract to directly decode ABI from response stream, eliminated mutex usage, and simplified error handling.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant HTTPClient
    participant abi

    Caller->>HTTPClient: Send HTTP request for contract ABI
    HTTPClient-->>Caller: Return HTTP response (body stream)
    Caller->>abi: Parse ABI JSON directly from response body stream
    abi-->>Caller: Return parsed ABI or error

Loading

Possibly related PRs

• thirdweb-dev/insight#213: Reverses this PR's approach by adding a mutex and intermediate response body reading for ABI parsing, addressing concurrency in a different way.
• thirdweb-dev/insight#208: Also modifies GetABIForContract, focusing on HTTP response handling and JSON decoding, but adds body closing and status code checks.

Suggested reviewers

• AmineAfia
• catalyst17
• nischitpra

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 856a78e and 7d03f9e.

📒 Files selected for processing (1)

• internal/common/abi.go (2 hunks)

🔇 Additional comments (2)

internal/common/abi.go (2)

69-73: Excellent simplification of ABI parsing logic.

The direct parsing from resp.Body is more efficient than the previous approach that read the entire response into memory first. This change:

• Reduces memory allocation by avoiding intermediate buffering
• Simplifies error handling
• Maintains the same functionality while being more resource-efficient
• Properly handles the response stream without losing any error information

This revert successfully addresses the unnecessary complexity that was likely introduced in PR #213.

---

17-18:

✅ Verification successful

Verify thread safety after mutex removal.

The removal of jsonDecodeMutex simplifies the code, but we should ensure that concurrent calls to abi.JSON() are safe. The go-ethereum library's ABI parsing should be thread-safe since it doesn't maintain global state, but this should be verified.

---

🏁 Script executed:

#!/bin/bash
# Description: Check if there are concurrent calls to GetABIForContract that might be affected by mutex removal
# Expected: Find usage patterns to assess concurrent access risk

echo "Searching for concurrent usage patterns of GetABIForContract..."
rg -A 10 -B 5 "GetABIForContract" --type go

echo -e "\nSearching for goroutine usage with ABI functions..."
rg -A 5 -B 5 "go.*GetABI" --type go

echo -e "\nSearching for sync patterns in the codebase..."
rg -A 3 -B 3 "sync\." --type go | head -20

Length of output: 5241

---

No thread‐safety issues with ABI parsing
Removal of the jsonDecodeMutex is safe because abi.JSON() builds and returns a new ABI instance each time without touching any global state. Additionally, all call sites that share an ABI cache (via GetABIForContractWithCache) already synchronize access with a sync.Mutex.

No further changes required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iuwqyir]

• Revert "improve abi parsing (#213)" #214 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.