remove validate query checks

[iuwqyir]

TL;DR

Removed query validation functionality from the codebase. Database users should have the necessary access restrictions instead.

What changed?

• Removed the ValidateQuery function from internal/common/utils.go
• Removed related variables (allowedFunctions and disallowedPatterns)
• Removed unused imports (fmt, regexp, and strings) from utils.go
• Removed calls to ValidateQuery in internal/storage/clickhouse.go

How to test?

1. Verify that queries still execute correctly in the ClickHouse connector
2. Confirm that previously disallowed queries now execute without validation errors
3. Run the test suite to ensure no regressions in functionality

Why make this change?

The query validation was likely too restrictive or causing issues with legitimate queries. Removing this validation allows for more flexibility in query construction and execution, potentially enabling more complex queries that were previously blocked by the validation rules.

Summary by CodeRabbit

• Refactor
  • Removed internal query validation checks prior to executing database queries. Queries are now executed directly without additional validation steps.

[coderabbitai]

Walkthrough

The changes remove all SQL query validation logic from the codebase. This includes deleting the ValidateQuery function and its supporting data structures from the utilities file, as well as eliminating all calls to this function in the ClickHouse storage implementation. No other logic is altered.

Changes

Cohort / File(s)	Change Summary
Query Validation Logic Removal internal/common/utils.go	Removed the ValidateQuery function, its supporting data structures (allowedFunctions, disallowedPatterns), and related imports.
Validation Call Removal in Storage internal/storage/clickhouse.go	Deleted all invocations of common.ValidateQuery(query) from GetAggregations and executeQuery functions. No other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 843dbc2 and 40e2c5e.

📒 Files selected for processing (2)

• internal/common/utils.go (0 hunks)
• internal/storage/clickhouse.go (0 hunks)

💤 Files with no reviewable changes (2)

• internal/storage/clickhouse.go
• internal/common/utils.go

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 07-29-remove_validate_query_checks

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[iuwqyir]

• remove validate query checks #252 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.