Skip to content

configurable committer kafka batch size #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

configurable committer kafka batch size #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configs/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ type Config struct {
CommitterKafkaEnableTLS bool `env:"COMMITTER_KAFKA_ENABLE_TLS" envDefault:"true"`
CommitterMaxMemoryMB int `env:"COMMITTER_MAX_MEMORY_MB" envDefault:"512"`
CommitterCompressionThresholdMB int `env:"COMMITTER_COMPRESSION_THRESHOLD_MB" envDefault:"50"`
CommitterKafkaBatchSize int `env:"COMMITTER_KAFKA_BATCH_SIZE" envDefault:"500"`
StagingS3Bucket string `env:"STAGING_S3_BUCKET" envDefault:"thirdweb-insight-production"`
StagingS3Region string `env:"STAGING_S3_REGION" envDefault:"us-west-2"`
StagingS3AccessKeyID string `env:"STAGING_S3_ACCESS_KEY_ID"`
Expand Down
6 changes: 3 additions & 3 deletions internal/committer/blockprocessorroutine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func processBlocks() {
indexerName := config.Cfg.ZeetProjectName

totalBytesInBatch := uint64(0)
blockBatch := make([]*common.BlockData, 0, 500)
blockBatch := make([]*common.BlockData, 0, config.Cfg.CommitterKafkaBatchSize)
defer func() {
releaseMemoryPermit(totalBytesInBatch)
}()
Expand All @@ -37,7 +37,7 @@ func processBlocks() {
if block.Acquired {
totalBytesInBatch += block.ByteSize
}
if len(blockBatch) == 500 {
if len(blockBatch) == config.Cfg.CommitterKafkaBatchSize {
if err := libs.KafkaPublisherV2.PublishBlockData(blockBatch); err != nil {
log.Panic().
Err(err).
Expand All @@ -56,7 +56,7 @@ func processBlocks() {
Uint64("memory_released_bytes", totalBytesInBatch).
Msg("Successfully published batch to Kafka")

blockBatch = make([]*common.BlockData, 0, 500)
blockBatch = make([]*common.BlockData, 0, config.Cfg.CommitterKafkaBatchSize)
}

nextBlockNumber++
Expand Down
Loading