Add time import to ClickHouse storage module #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iuwqyir
changed the title
AmineAfia
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added time package import to clickhouse.go file.
What changed?
The
timepackage from the Go standard library has been imported in theinternal/storage/clickhouse.gofile.How to test?
No specific testing is required for this change as it's an import addition. However, ensure that the build process completes successfully and that any existing tests pass without errors.
Why make this change?
The addition of the
timepackage import suggests that time-related functionality will be used in the clickhouse storage implementation. This could be for handling timestamps, durations, or other time-based operations within the storage layer.