Smart wallet session key auto-creation doesn't take into account permissions when skipping

[alecananian]

I'd like to take advantage of the new sessionKey options in smart wallet creation params from #6194, but the current implementation that checks for an existing key only checks for an active signer, rather than confirming the full permissions scope. If the current session supports approvedTargets: [ContractA], but I request approvedTargets: [ContractA, ContractB] on a subsequent connection, the request will be skipped and the session will be missing ContractB approval. The same is true for mismatched nativeTokenLimitPerTransaction values.

[linear]

TOOL-3349 Smart wallet session key auto-creation doesn't take into account permissions when skipping

[joaquim-verges]

great call out @alecananian, I put upt a PR here: #6217 can you double check that the logic makes sense to you?

Also exposed the utility function i use internally in case you want to customize your own flow

[alecananian]

Added some comments, but it's a bit of an implementation choice I suppose. On our end we treat the new session key request as a request for "at least all of these requirements" rather than "exactly all of these requirements". So if a session is requested that's a subset of an existing one, the request is ignored. But if that's not the way you'd like to implement this helper, then that makes sense to me, too!