Skip to content

Conversation

@b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Sep 10, 2022

Fixes #83

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

⚠️ No Changeset found

Latest commit: cac00a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jarrodwatts
Copy link
Contributor

Thanks Mahesh! This looks great.

One question - when you create the project - is the name transformed to lowercase?

This seems like the validation is changed but the actual project name doesn't get transformed.

e.g. if I type ethBio my project name should be ethbio

@jarrodwatts jarrodwatts changed the title convert app name to lower [CLI] - Don't show error when non lowercase letter is entered for project name Sep 11, 2022
@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Sep 12, 2022

@jarrodwatts Right now we don't allow the appName to be the package name in json file. This PR only fixes validation which is stopping the user to create the repo. The other PR I can edit that to support the same in package.json as well.

@jnsdls
Copy link
Member

jnsdls commented Sep 12, 2022

Thanks for the PR! Please add a changeset (using yarn changeset) that briefly describes what these changes mean to a user.

In this case it can probably be a patch version change.

@jarrodwatts
Copy link
Contributor

What I mean is that this change allows you to create a project with capital letters; which isn't the ideal behaviour, we should:

  1. Hide the warning
  2. Lowercase the directory name that the project creates

@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Sep 12, 2022

Oh cool. Got it. Will update the code.

@jnsdls
Copy link
Member

jnsdls commented Sep 22, 2022

fixed in #184

@jnsdls jnsdls closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] - Fix "Invalid Project name" when a project with a capital letter is entered

4 participants