Skip to content

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Sep 27, 2023

Problem solved

Fix thirdweb create with options

You can now correctly call:

  • npx thirdweb create --react
  • npx thirdweb create --next
  • npx thirdweb create --vite
  • npx thirdweb create --node
  • npx thirdweb create --express
  • npx thirdweb create --pwaVite
  • npx thirdweb create --reactNative

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@iketw iketw requested a review from a team as a code owner September 27, 2023 15:58
@iketw iketw requested a review from a team September 27, 2023 15:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: cb35661

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iketw iketw enabled auto-merge September 27, 2023 15:58
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@iketw iketw added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 879d422 Sep 27, 2023
@iketw iketw deleted the ike/cli branch September 27, 2023 17:04
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Update account-abstraction.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants