[SmartWallets] Fix gas estimation for first SW transaction #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb7af09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Merged
jnsdls
pushed a commit
that referenced
this pull request
Jun 19, 2024
….22 (#1681) Bumps [@solana/wallet-adapter-wallets](https://github.com/solana-labs/wallet-adapter) from 0.19.19 to 0.19.22. - [Release notes](https://github.com/solana-labs/wallet-adapter/releases) - [Commits](https://github.com/solana-labs/wallet-adapter/compare/@solana/wallet-adapter-wallets@0.19.19...@solana/wallet-adapter-wallets@0.19.22) --- updated-dependencies: - dependency-name: "@solana/wallet-adapter-wallets" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
first SW transaction can run out of gas due to how we estimate gas for non deployed accounts. Added a 20% buffer to remediate, can probably be more accurate but this will help for now.
Changes made
How to test