Skip to content

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 14, 2023

Problem solved

Continuous work for #1648

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2023

🦋 Changeset detected

Latest commit: 6dc93dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/common/marketplace.ts 74.68% <100.00%> (-0.63%) ⬇️
.../sdk/src/evm/core/classes/drop-claim-conditions.ts 77.28% <100.00%> (-0.17%) ⬇️
...es/sdk/src/evm/core/classes/marketplace-auction.ts 73.33% <100.00%> (ø)
...ges/sdk/src/evm/core/classes/marketplace-direct.ts 81.14% <100.00%> (ø)
.../evm/core/classes/marketplacev3-direct-listings.ts 68.36% <100.00%> (ø)
.../evm/core/classes/marketplacev3-english-auction.ts 73.29% <100.00%> (ø)
...any-evm-utils/fetchPublishedContractFromPolygon.ts 62.50% <0.00%> (-2.02%) ⬇️
.../src/evm/common/any-evm-utils/getDeploymentInfo.ts 62.00% <50.00%> (-0.27%) ⬇️

📢 Thoughts on this report? Let us know!.

@kien-ngo kien-ngo marked this pull request as ready for review October 14, 2023 15:26
@kien-ngo kien-ngo requested review from a team and joaquim-verges October 14, 2023 15:26
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@kien-ngo kien-ngo enabled auto-merge October 14, 2023 21:07
@kien-ngo kien-ngo added this pull request to the merge queue Oct 14, 2023
Merged via the queue into main with commit 526176c Oct 14, 2023
@kien-ngo kien-ngo deleted the kien/improv_marketplace branch October 14, 2023 21:21
@github-actions github-actions bot mentioned this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants