Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jun 4, 2024

PR-Codex overview

The focus of this PR is to add a new hook useWalletDetailsModal and make various updates related to client handling and UI components.

Detailed summary

  • Added useWalletDetailsModal hook
  • Updated exports related to wallet details modal
  • Modified components to handle client prop
  • Adjusted UI components for better functionality

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jun 4, 2024

@vercel
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 5:27pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: b22df5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Minor
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MananTank MananTank marked this pull request as draft June 4, 2024 16:46
@MananTank
Copy link
Member Author

/release-pr

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 4, 2024

CodSpeed Performance Report

Merging #3229 will not alter performance

Comparing cnct-1327 (b22df5c) with main (5d47e50)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.37 KB (0%) 808 ms (0%) 587 ms (+69.71% 🔺) 1.4 s
thirdweb (cjs) 89.34 KB (0%) 1.8 s (0%) 1.5 s (+32.48% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 135 ms (+460.81% 🔺) 230 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 21 ms (+156.07% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 124 ms (-16.32% 🔽) 439 ms

@MananTank MananTank assigned MananTank and unassigned MananTank Jun 4, 2024
@MananTank MananTank marked this pull request as ready for review June 4, 2024 17:36
const activeChain = useActiveWalletChain();
const chainId = activeChain?.id;
const { connectLocale, client } = useConnectUI();
const { connectLocale, client } = props;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, less context dependency!

@codecov
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 44.67593% with 239 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (5d47e50) to head (b22df5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
- Coverage   63.31%   63.28%   -0.03%     
==========================================
  Files         832      832              
  Lines       63007    63281     +274     
  Branches     3426     3426              
==========================================
+ Hits        39892    40048     +156     
- Misses      22438    22556     +118     
  Partials      677      677              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 5d47e50
packages 62.79% <44.67%> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx 57.70% <100.00%> (+0.27%) ⬆️
...es/thirdweb/src/react/web/ui/hooks/useSendToken.ts 26.56% <100.00%> (+0.40%) ⬆️
...irdweb/src/react/web/wallets/shared/ScanScreen.tsx 21.93% <60.00%> (+1.02%) ⬆️
...eact/web/ui/ConnectWallet/screens/ReceiveFunds.tsx 24.73% <40.00%> (+0.28%) ⬆️
...act/web/wallets/shared/WalletConnectConnection.tsx 13.98% <0.00%> (-0.20%) ⬇️
...c/react/web/ui/ConnectWallet/screens/SendFunds.tsx 11.40% <12.50%> (-0.13%) ⬇️
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 23.32% <45.29%> (+8.73%) ⬆️

@MananTank MananTank added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit e7b9b9f Jun 5, 2024
@MananTank MananTank deleted the cnct-1327 branch June 5, 2024 15:10
@jnsdls jnsdls mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants