feat: TransactionButton react native implementation #3231

joaquim-verges · 2024-06-05T00:35:07Z

PR-Codex overview

This PR implements the TransactionButton component in React Native and updates imports to core/design-system across various files.

Detailed summary

Added TransactionButton React Native implementation
Updated imports to core/design-system in multiple files for consistency

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/ui/components/formElements.tsx, packages/thirdweb/src/react/web/ui/components/OTPInput.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/EstimatedTimeAndFees.tsx, packages/thirdweb/src/react/web/ui/components/Spinner.tsx, packages/thirdweb/src/react/web/wallets/in-app/CountrySelector.tsx, packages/thirdweb/src/react/web/ui/components/TokenIcon.tsx, packages/thirdweb/src/react/web/ui/components/QRCode.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/PaymentSelection.tsx, packages/thirdweb/src/react/web/wallets/in-app/InputSelectionUI.tsx, packages/thirdweb/src/react/web/ui/components/Drawer.tsx, packages/thirdweb/src/react/web/ui/components/basic.tsx, packages/thirdweb/src/react/web/ui/components/DragNDrop.tsx, packages/thirdweb/src/react/web/wallets/shared/ConnectingScreen.tsx, packages/thirdweb/src/react/web/ui/components/WalletImage.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/WalletLogoSpinner.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/TokenSelector.tsx, packages/thirdweb/src/react/web/wallets/shared/ScanScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ViewFunds.tsx, packages/thirdweb/src/react/web/ui/design-system/CustomThemeProvider.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/tx-history/BuyTxHistory.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx, packages/thirdweb/src/react/web/ui/components/Modal.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/PayWIthCreditCard.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/StartScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SendFunds.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/PostOnRampSwap.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx, packages/thirdweb/src/react/web/ui/PayEmbed.tsx, packages/thirdweb/src/exports/react.ts, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletSocialLogin.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletPassKeyLogin.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/tx-history/BuyTxHistoryButton.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModalInline.tsx, packages/thirdweb/src/react/native/ui/components/button.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/SwapStatusScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatStatusScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/NetworkSelector.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/tx-history/SwapDetailsScreen.tsx, packages/thirdweb/src/react/native/ui/components/text.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/WalletEntryButton.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ReceiveFunds.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SignatureScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/BuyTokenInput.tsx, packages/thirdweb/src/react/web/hooks/useSendTransaction.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx, packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletOTPLoginUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletFormUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/TokenSelector.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/ConfirmationScreen.tsx, packages/thirdweb/src/react/native/ui/TransactionButton/TrabsactionButton.tsx, packages/thirdweb/src/react/core/hooks/transaction/button-core.ts, packages/thirdweb/src/react/web/ui/TransactionButton/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-06-05T00:35:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2024 11:38pm

changeset-bot · 2024-06-05T00:35:10Z

🦋 Changeset detected

Latest commit: daff4da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Minor
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2024-06-05T00:37:59Z

CodSpeed Performance Report

Merging #3231 will not alter performance

_{Comparing joaquim/rn-ui (daff4da) with main (63b4e6c)}

Summary

✅ 9 untouched benchmarks

github-actions · 2024-06-05T00:38:49Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.37 KB (0%)	808 ms (0%)	390 ms (+12.49% 🔺)	1.2 s
thirdweb (cjs)	89.34 KB (0%)	1.8 s (0%)	875 ms (+15.26% 🔺)	2.7 s
thirdweb (minimal + tree-shaking)	4.75 KB (0%)	95 ms (0%)	145 ms (+844.59% 🔺)	240 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	38 ms (+519.31% 🔺)	48 ms
thirdweb/react (minimal + tree-shaking)	15.75 KB (0%)	315 ms (0%)	125 ms (+123.63% 🔺)	440 ms

codecov · 2024-06-05T00:44:14Z

Codecov Report

Attention: Patch coverage is 93.18182% with 27 lines in your changes missing coverage. Please review.

Project coverage is 63.35%. Comparing base (63b4e6c) to head (daff4da).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3231      +/-   ##
==========================================
+ Coverage   63.28%   63.35%   +0.06%     
==========================================
  Files         832      833       +1     
  Lines       63282    63389     +107     
  Branches     3427     3428       +1     
==========================================
+ Hits        40049    40157     +108     
+ Misses      22556    22555       -1     
  Partials      677      677

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.61% <ø> (ø)`		Carriedforward from 63b4e6c
packages	`62.87% <93.18%> (+0.07%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...c/react/core/design-system/CustomThemeProvider.tsx	`91.30% <100.00%> (ø)`
...ges/thirdweb/src/react/core/design-system/index.ts	`90.87% <100.00%> (ø)`
...hirdweb/src/react/web/hooks/useSendTransaction.tsx	`40.52% <100.00%> (ø)`
.../react/web/providers/wallet-ui-states-provider.tsx	`90.66% <100.00%> (ø)`
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx	`57.70% <100.00%> (ø)`
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	`23.32% <100.00%> (ø)`
...eb/ui/ConnectWallet/Modal/ConnectModalSkeleton.tsx	`28.33% <100.00%> (ø)`
...t/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx	`35.63% <100.00%> (ø)`
...eb/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx	`10.46% <100.00%> (+1.31%)`	⬆️
...src/react/web/ui/ConnectWallet/NetworkSelector.tsx	`21.48% <100.00%> (ø)`
... and 53 more

joaquim-verges added 3 commits June 5, 2024 11:26

TransactionButton react native implementation

e692d50

jsdoc cleanup

fef0fb4

let users override button style

4b1e49f

joaquim-verges requested a review from jnsdls June 5, 2024 00:35

joaquim-verges requested a review from MananTank as a code owner June 5, 2024 00:35

Merge remote-tracking branch 'origin/main' into joaquim/rn-ui

a55ca94

vercel bot deployed to Preview June 5, 2024 19:55 View deployment

Merge branch 'main' into joaquim/rn-ui

daff4da

vercel bot deployed to Preview June 5, 2024 23:38 View deployment

joaquim-verges merged commit dbf74aa into main Jun 6, 2024

joaquim-verges deleted the joaquim/rn-ui branch June 6, 2024 00:06

jnsdls mentioned this pull request Jun 6, 2024

Version Packages #3234

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: TransactionButton react native implementation #3231

feat: TransactionButton react native implementation #3231

Uh oh!

joaquim-verges commented Jun 5, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Jun 5, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 5, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jun 5, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 5, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jun 5, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: TransactionButton react native implementation #3231

feat: TransactionButton react native implementation #3231

Uh oh!

Conversation

joaquim-verges commented Jun 5, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #3231 will not alter performance

Summary

Uh oh!

github-actions bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Jun 5, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Jun 5, 2024 •

edited

Loading

changeset-bot bot commented Jun 5, 2024 •

edited

Loading

codspeed-hq bot commented Jun 5, 2024 •

edited

Loading

github-actions bot commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 5, 2024 •

edited

Loading