Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jun 5, 2024

Our documentation lists the EIP-5792 hooks as exported from thirdweb/react, which is more consistent than the current export from wallets


PR-Codex overview

This PR focuses on adding EIP-5792 hook exports to thirdweb/react.

Detailed summary

  • Added EIP-5792 hook exports to thirdweb/react
  • Exported useSendCalls from ../react/core/hooks/wallets/useSendCalls.js
  • Exported useCallsStatus from ../react/core/hooks/wallets/useCallsStatus.js
  • Exported useCapabilities from ../react/core/hooks/wallets/useCapabilities.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:39pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 061ce74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #3235 will improve performances by 10.59%

Comparing greg/export-5792-hooks (061ce74) with main (e7b9b9f)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main greg/export-5792-hooks Change
keccakId 1.5 ms 1.3 ms +10.59%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.37 KB (0%) 808 ms (0%) 457 ms (+65.83% 🔺) 1.3 s
thirdweb (cjs) 89.34 KB (0%) 1.8 s (0%) 1.1 s (+69.4% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 117 ms (+412.8% 🔺) 212 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 104 ms (+1208.83% 🔺) 114 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 191 ms (+248.34% 🔺) 506 ms

@codecov
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.28%. Comparing base (e7b9b9f) to head (061ce74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3235   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         832      832           
  Lines       63281    63281           
  Branches     3426     3426           
=======================================
  Hits        40048    40048           
  Misses      22556    22556           
  Partials      677      677           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from e7b9b9f
packages 62.79% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 824a631 Jun 5, 2024
@joaquim-verges joaquim-verges deleted the greg/export-5792-hooks branch June 5, 2024 22:57
@jnsdls jnsdls mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants