-
Notifications
You must be signed in to change notification settings - Fork 621
fix: resolves viem#2306 #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolves viem#2306 #3237
Conversation
|
@jxom is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
|
|
thanks for this @jxom ! Not lowercasing strings types makes sense, but I'm actually surprised we need this lowercasing of address types in the first place, would have expected checksum instead. Can you point me to some resources to understand why addresses need to be lowercased before sending with |
CodSpeed Performance ReportMerging #3237 will degrade performances by 16.01%Comparing Summary
Benchmarks breakdown
|
|
Not all Wallets behave correctly when they are passed a checksum address. Can’t remember off the top of my head which Wallets didn’t behave correctly. This behavior exists in Ethers as well. Even if we think it may not be an issue anymore, I don’t think it is worth the risk. Typed data spec is brittle in itself. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/viem@2.10.9 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
===========================================
- Coverage 63.35% 52.32% -11.03%
===========================================
Files 833 828 -5
Lines 63389 63026 -363
Branches 3428 2576 -852
===========================================
- Hits 40157 32980 -7177
- Misses 22555 29376 +6821
+ Partials 677 670 -7
*This pull request uses carry forward flags. Click here to find out more.
|
Fixes issue related to: wevm/viem#2306
PR-Codex overview
This PR updates various files in
thirdwebpackage related to Ethereum adapters, wallet functions, package dependencies, and test cases.Detailed summary
ethers6.tsandethers5.tsto includeaccessListpropertypackage.jsonwith new versions for dependenciesserializeTypedData