Skip to content

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Jun 6, 2024

Problem solved

Exposes domain and bundle id validation logic for use in ecosystem wallets

Changes made

  • Public API changes: exposes authorizeDomain and authorizeBundleId
  • Internal API changes: None

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

PR-Codex overview

This PR exposes domain and bundle Id validation logic in service-utils.

Detailed summary

  • Exposed authorizeDomain and authorizeBundleId functions for validation
  • Updated authorizeClient to use the new functions for validation
  • Added logic for domain and bundle Id validation in authorizeDomain and authorizeBundleId functions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@ElasticBottle ElasticBottle requested a review from arcoraven as a code owner June 6, 2024 07:29
@vercel
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 7:29am

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: ea89f08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ElasticBottle
Copy link
Contributor Author

/release-pr

@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (8acf564) to head (ea89f08).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3238   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files         833      833           
  Lines       63389    63389           
  Branches     3428     3428           
=======================================
  Hits        40157    40157           
  Misses      22555    22555           
  Partials      677      677           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 8acf564
packages 62.87% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #3238 will not alter performance

Comparing winston/service-utils-expose-domain-validation (ea89f08) with main (dbf74aa)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.37 KB (0%) 808 ms (0%) 3.5 s (+45.14% 🔺) 4.3 s
thirdweb (cjs) 89.34 KB (0%) 1.8 s (0%) 7.7 s (+5.55% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 104 ms (-64.85% 🔽) 199 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 69 ms (-34.21% 🔽) 79 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 454 ms (-16.88% 🔽) 769 ms

@joaquim-verges joaquim-verges added this pull request to the merge queue Jun 8, 2024
Merged via the queue into main with commit 73af67a Jun 8, 2024
@joaquim-verges joaquim-verges deleted the winston/service-utils-expose-domain-validation branch June 8, 2024 03:20
@jnsdls jnsdls mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants