Fix custom theme not used in ConnectEmbed loading screen #3240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7dc8ed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #3240 will degrade performances by 14.12%Comparing Summary
Benchmarks breakdown
|
Contributor
size-limit report 📦
|
Member
Author
|
/release-pr |
joaquim-verges
approved these changes
Jun 8, 2024
| <EmbedContainer modalSize={modalSize}> | ||
| <LoadingScreen /> | ||
| </EmbedContainer> | ||
| <CustomThemeProvider theme={props.theme || "dark"}> |
Member
There was a problem hiding this comment.
feels like we should be passing the theme object around. doing that for RN
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR fixes the issue where the custom theme was not applied in the ConnectEmbed loading screen in
ConnectEmbed.tsx.Detailed summary
CustomThemeProviderimport and usageEmbedContainerinCustomThemeProviderwith the provided theme or default to "dark"