Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 7, 2024

PR-Codex overview

This PR fixes a bug in the resolveScheme function for v1 IPFS schemes in the thirdweb package.

Detailed summary

  • Updated regex pattern to fix IPFS scheme resolution bug
  • Added a test case for resolving IPFS scheme with client and URI
  • Modified the expected URL in the test case to match the resolved IPFS scheme

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 10:42am

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: d63cdb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #3241 will not alter performance

Comparing jd/fix-ipfs-reolve-scheme-bug (d63cdb9) with main (558885a)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.29 KB (+0.01% 🔺) 806 ms (+0.01% 🔺) 3.7 s (-0.48% 🔽) 4.5 s
thirdweb (cjs) 89.94 KB (+0.07% 🔺) 1.8 s (+0.07% 🔺) 7.6 s (+3.44% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 418 ms (+103.88% 🔺) 513 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 147 ms (+76.99% 🔺) 157 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 427 ms (-26.8% 🔽) 742 ms

@codecov
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (558885a) to head (d63cdb9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3241   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files         833      833           
  Lines       63393    63393           
  Branches     3425     3426    +1     
=======================================
  Hits        40147    40147           
  Misses      22571    22571           
  Partials      675      675           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from 558885a
packages 62.85% <100.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/thirdweb/src/utils/ipfs.ts 86.42% <100.00%> (ø)

@jnsdls jnsdls added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 37ec4ca Jun 7, 2024
@jnsdls jnsdls deleted the jd/fix-ipfs-reolve-scheme-bug branch June 7, 2024 10:55
@jnsdls jnsdls mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants