Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 7, 2024

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:


PR-Codex overview

This PR increases the size limit for the thirdweb (esm) package and refines the user authorization check in the release workflow.

Detailed summary

  • Increased size limit for thirdweb (esm) to 45 kB
  • Refined user authorization check in release workflow to exclude 'CONTRIBUTOR' role

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:22pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: f5d4201

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

jnsdls commented Jun 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@jnsdls jnsdls marked this pull request as ready for review June 7, 2024 21:19
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #3243 will not alter performance

Comparing enhancement/adjust-workflow-and-size-limits (f5d4201) with main (37ec4ca)

Summary

✅ 9 untouched benchmarks

@codecov
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (37ec4ca) to head (f5d4201).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3243   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files         833      833           
  Lines       63393    63393           
  Branches     3426     3426           
=======================================
  Hits        40147    40147           
  Misses      22571    22571           
  Partials      675      675           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from 37ec4ca
packages 62.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.29 KB (0%) 806 ms (0%) 4.6 s (+90.36% 🔺) 5.4 s
thirdweb (cjs) 89.94 KB (0%) 1.8 s (0%) 9.2 s (+48.98% 🔺) 11 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 490 ms (+350.39% 🔺) 585 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 151 ms (+64.63% 🔺) 161 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 661 ms (+102.22% 🔺) 976 ms

@jnsdls jnsdls requested a review from joaquim-verges June 7, 2024 21:53
@joaquim-verges joaquim-verges added this pull request to the merge queue Jun 7, 2024
Copy link
Member Author

jnsdls commented Jun 7, 2024

Merge activity

  • Jun 7, 6:48 PM EDT: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

Merged via the queue into main with commit f66161f Jun 7, 2024
@joaquim-verges joaquim-verges deleted the enhancement/adjust-workflow-and-size-limits branch June 7, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants