fix: sign typed data using inAppWalelt with salt in domain

[joaquim-verges]

PR-Codex overview

This PR focuses on fixing sign typed data in the in-app wallet when the domain contains a salt param.

Detailed summary

• Updated handling of chainId to use TypedDataDefinition["domain"]
• Refactored domain object assignment to include specific properties like verifyingContract, name, and version

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

🦋 Changeset detected

Latest commit: c14bdfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 10, 2024 11:05pm

[joaquim-verges]

/release-pr

[codspeed-hq]

CodSpeed Performance Report

Merging #3266 will not alter performance

_{Comparing joaquim/fix_signtypeddata_inapp (c14bdfd) with main (f2004b5)}

Summary

✅ 9 untouched benchmarks

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.29 KB (0%)	806 ms (0%)	2.9 s (-5.93% 🔽)	3.7 s
thirdweb (cjs)	89.94 KB (0%)	1.8 s (0%)	7.2 s (+0.67% 🔺)	9 s
thirdweb (minimal + tree-shaking)	4.75 KB (0%)	95 ms (0%)	310 ms (+22.48% 🔺)	405 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	41 ms (-37.39% 🔽)	51 ms
thirdweb/react (minimal + tree-shaking)	15.75 KB (0%)	315 ms (0%)	909 ms (+119.38% 🔺)	1.3 s

[jnsdls]

/release-pr

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (f2004b5) to head (c14bdfd).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
- Coverage   63.32%   63.32%   -0.01%     
==========================================
  Files         833      833              
  Lines       63394    63394              
  Branches     3423     3425       +2     
==========================================
- Hits        40145    40142       -3     
- Misses      22574    22577       +3     
  Partials      675      675              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.60% <ø> (ø)		Carriedforward from f2004b5
packages	62.84% <ø> (-0.01%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes