-
Notifications
You must be signed in to change notification settings - Fork 620
Add position relative on all Shadcn/Chakra AspectRatio component replacement divs #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add position relative on all Shadcn/Chakra AspectRatio component replacement divs #4801
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4801 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 1051 1051
Lines 56679 56679
Branches 3892 3892
=======================================
Hits 27846 27846
Misses 28200 28200
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix. will check once it's built
Merge activity
|
…acement divs (#4801) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating various components to add the `relative` class to `div` elements that define aspect ratios, enhancing layout control and positioning. ### Detailed summary - Added `relative` class to `div` elements in: - `GameShowcase.tsx` for aspect ratios `16/9` - `GuideCard.tsx` for aspect ratios `2400/1260` - `airdrop-upload-erc20.tsx` for aspect ratios `21/9` - `chain-header.tsx` for conditional aspect ratios - `airdrop-upload.tsx` for aspect ratios `21/9` - `snapshot-upload.tsx` for aspect ratios `21/9` - `upload-step.tsx` for aspect ratio `square` - `NFTCards.tsx` for aspect ratio `square` - `MarketplaceDetails.tsx` for aspect ratio `square` - `dropzone.tsx` for aspect ratio adjustments - `WithoutThirdwebSection.tsx` for aspect ratios `16/10` - `logo/index.tsx` for aspect ratio `516/321` - Updated `Logo` component for aspect ratio `1377/267` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
8d202e9 to
8e9d13c
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the layout of various components by adding the
relativeclass todivelements with specific aspect ratios, improving their positioning and responsiveness.Detailed summary
relativeclass todivelements with aspect ratios in:GameShowcase.tsxGuideCard.tsxairdrop-upload-erc20.tsxchain-header.tsxairdrop-upload.tsxsnapshot-upload.tsxupload-step.tsxNFTCards.tsxMarketplaceDetails.tsxdropzone.tsxWithoutThirdwebSection.tsxindex.tsx(logo component)