Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Sep 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the layout of various components by adding the relative class to div elements with specific aspect ratios, improving their positioning and responsiveness.

Detailed summary

  • Added relative class to div elements with aspect ratios in:
    • GameShowcase.tsx
    • GuideCard.tsx
    • airdrop-upload-erc20.tsx
    • chain-header.tsx
    • airdrop-upload.tsx
    • snapshot-upload.tsx
    • upload-step.tsx
    • NFTCards.tsx
    • MarketplaceDetails.tsx
    • dropzone.tsx
    • WithoutThirdwebSection.tsx
    • index.tsx (logo component)

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 3:43pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 25, 2024 3:43pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 25, 2024 3:43pm
wallet-ui ⬜️ Skipped (Inspect) Sep 25, 2024 3:43pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 15:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 15:30 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 8e9d13c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 15:30 Inactive
@MananTank MananTank marked this pull request as ready for review September 25, 2024 15:30
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (d35f0b2) to head (8e9d13c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4801   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files        1051     1051           
  Lines       56679    56679           
  Branches     3892     3892           
=======================================
  Hits        27846    27846           
  Misses      28200    28200           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d35f0b2
packages 45.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 761 ms (+73.71% 🔺) 1.6 s
thirdweb (cjs) 101.56 KB (0%) 2.1 s (0%) 1.2 s (+7.08% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 42 ms (-10.76% 🔽) 138 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 15 ms (-35.65% 🔽) 25 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 107 ms (-31.45% 🔽) 443 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

@kien-ngo kien-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix. will check once it's built

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Merge activity

…acement divs (#4801)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various components to add the `relative` class to `div` elements that define aspect ratios, enhancing layout control and positioning.

### Detailed summary
- Added `relative` class to `div` elements in:
  - `GameShowcase.tsx` for aspect ratios `16/9`
  - `GuideCard.tsx` for aspect ratios `2400/1260`
  - `airdrop-upload-erc20.tsx` for aspect ratios `21/9`
  - `chain-header.tsx` for conditional aspect ratios
  - `airdrop-upload.tsx` for aspect ratios `21/9`
  - `snapshot-upload.tsx` for aspect ratios `21/9`
  - `upload-step.tsx` for aspect ratio `square`
  - `NFTCards.tsx` for aspect ratio `square`
  - `MarketplaceDetails.tsx` for aspect ratio `square`
  - `dropzone.tsx` for aspect ratio adjustments
  - `WithoutThirdwebSection.tsx` for aspect ratios `16/10`
  - `logo/index.tsx` for aspect ratio `516/321`
  - Updated `Logo` component for aspect ratio `1377/267`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the 09-25-add_position_relative_on_all_shadcn_chakra_aspectratio_component_replacement_divs branch from 8d202e9 to 8e9d13c Compare September 25, 2024 15:40
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 15:40 Inactive
@graphite-app graphite-app bot merged commit 8e9d13c into main Sep 25, 2024
@graphite-app graphite-app bot deleted the 09-25-add_position_relative_on_all_shadcn_chakra_aspectratio_component_replacement_divs branch September 25, 2024 15:44
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 25, 2024 15:44 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 25, 2024 15:44 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 25, 2024 15:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants