Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Sep 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the user interface by integrating account and team images through the GradientAvatar and ProjectAvatar components. It also refines data handling for account information across various components.

Detailed summary

  • Added GradientAvatar and ProjectAvatar for rendering user and project images.
  • Replaced email attributes with account objects in several components.
  • Updated UI elements to reflect account loading states.
  • Removed placeholder elements for images and replaced them with avatar components.
  • Adjusted props in multiple components to accommodate new account data structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 09b1c28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:46pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 26, 2024 8:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 26, 2024 8:46pm
wallet-ui ⬜️ Skipped (Inspect) Sep 26, 2024 8:46pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 16:47 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 25, 2024
Copy link
Member Author

MananTank commented Sep 25, 2024

@MananTank MananTank changed the title Replace Avatar placeholders with Avatar components in teams and account layout WIP - Replace Avatar placeholders with Avatar components in teams and account layout Sep 25, 2024
@MananTank MananTank marked this pull request as ready for review September 25, 2024 16:48
@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (98f2b56) to head (09b1c28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4803      +/-   ##
==========================================
- Coverage   49.13%   47.66%   -1.48%     
==========================================
  Files        1051     1051              
  Lines       56714    56714              
  Branches     3892     3892              
==========================================
- Hits        27868    27032     -836     
- Misses      28213    28995     +782     
- Partials      633      687      +54     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 98f2b56
packages 43.38% <ø> (-1.83%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 245 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 2.2 s (+1.32% 🔺) 3 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 4.8 s (+12.55% 🔺) 6.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 262 ms (-0.62% 🔽) 359 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 32 ms (-82.52% 🔽) 42 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 463 ms (-40.14% 🔽) 799 ms

@MananTank MananTank force-pushed the 09-25-add_img_component_with_skeleton_fallback_support branch from 6b0d04e to a323398 Compare September 25, 2024 17:28
@MananTank MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from e826645 to 47bbd5c Compare September 25, 2024 17:28
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 17:28 Inactive
@MananTank MananTank force-pushed the 09-25-add_img_component_with_skeleton_fallback_support branch from a323398 to b3b4b0b Compare September 25, 2024 19:06
@MananTank MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 47bbd5c to 9c194f8 Compare September 25, 2024 19:06
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 19:06 Inactive
@MananTank MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 9c194f8 to 80de57b Compare September 25, 2024 19:09
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 21:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 21:38 Inactive
@MananTank MananTank changed the title WIP - Replace Avatar placeholders with Avatar components in teams and account layout Replace Avatar placeholders with Avatar components in teams and account layout Sep 25, 2024
@MananTank MananTank requested a review from jnsdls September 26, 2024 07:56
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just update the get team by slug thing

@MananTank MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 2ca6b52 to 0ada3e8 Compare September 26, 2024 20:02
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 20:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 20:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 20:02 Inactive
@MananTank MananTank requested a review from jnsdls September 26, 2024 20:03
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 26, 2024

Merge activity

…nt layout (#4803)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating the account handling in various components to use an `account` object instead of separate email fields, and introduces new avatar components for enhanced visual representation of users and projects.

### Detailed summary
- Replaced `email` with `account` in multiple components.
- Introduced `GradientAvatar` and `ProjectAvatar` components for displaying user and project images.
- Updated story files to showcase new avatar components.
- Added placeholder comments for future image integration.
- Adjusted layout and styling for better alignment with new account structure.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch from 0ada3e8 to 09b1c28 Compare September 26, 2024 20:43
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 20:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 20:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 20:43 Inactive
@graphite-app graphite-app bot merged commit 09b1c28 into main Sep 26, 2024
@graphite-app graphite-app bot deleted the 09-25-replace_avatar_placeholders_with_avatar_components_in_teams_and_account_layout branch September 26, 2024 20:47
@vercel vercel bot temporarily deployed to Production – wallet-ui September 26, 2024 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 26, 2024 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 26, 2024 20:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants