[Dashboard] Remove react-icons (2) #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
MananTank
reviewed
Oct 2, 2024
MananTank
reviewed
Oct 2, 2024
MananTank
reviewed
Oct 2, 2024
MananTank
reviewed
Oct 2, 2024
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
b7a8da6 to
df8d4ef
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
df8d4ef to
c20f14e
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
5b4e974 to
4323035
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
4323035 to
719338d
Compare
MananTank
approved these changes
Oct 3, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on replacing icon imports from `react-icons` with corresponding icons from `lucide-react` across multiple components, enhancing consistency and potentially reducing bundle size.
### Detailed summary
- Replaced `FiCopy` with `CopyIcon` in `AddressCopyButton`.
- Replaced `MdOutlineAccountBalanceWallet` with `WalletIcon` in `TransactionSimulator`.
- Replaced `FiMoon` and `FiSun` with `MoonIcon` and `SunIcon` in `ColorModeToggle`.
- Replaced `FiTrash` with `Trash2Icon` in `SettingsMetadata`.
- Added `PlusIcon` and `Trash2Icon` in `metadata.tsx`.
- Replaced `FiPlus` with `PlusIcon` in `permissions-editor.tsx`.
- Replaced `BsFillLightningChargeFill` with `ZapIcon` in `contact-us.tsx`.
- Replaced `BsFillLightningChargeFill` with `ZapIcon` in `contracts.tsx`.
- Replaced `IoChevronBack` with `ChevronFirstIcon` in `ContractPublishForm`.
- Replaced `IoChevronBack` with `ChevronLeftIcon` in `BatchLazyMint`.
- Replaced various `Md` icons with `Chevron` icons in `BatchTable`.
- Replaced `Chevron` icons in `airdrop-upload-erc20.tsx`.
- Replaced `FiExternalLink` with `MoveUpRightIcon` in `pricing.tsx`.
- Replaced `IoIosInformationCircleOutline` with `InfoIcon` in `pricing.tsx`.
- Replaced `IoCheckmarkCircle` with `CircleCheckIcon` in `pricing.tsx`.
- Replaced `AiOutlineDollarCircle` with `CircleDollarSignIcon` in `pricing.tsx`.
- Replaced `FiArrowRight` with `MoveRightIcon` in `marketplace-table.tsx`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
kien/remove-react-icons-2
branch
from
719338d to
d1d3fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing icon imports from
react-iconswith icons fromlucide-reactacross various components in the dashboard application, enhancing consistency and potentially improving performance.Detailed summary
FiCopywithCopyIconinAddressCopyButton.ArrowDownwithArrowDownand addedWalletIconinTransactionSimulator.FiMoonandFiSunwithMoonIconandSunIconinColorModeToggle.FiTrashwithTrash2IconinSettingsMetadata.PlusIconinpermissions-editor.BsFillLightningChargeFillwithZapIconinContactUsandContracts.IoChevronBackwithChevronFirstIconinContractPublishForm.ChevronLeftIcon,ChevronRightIcon, andChevronLastIconinBatchTable.AirdropTablewithChevron*Icon.FiExternalLinkwithMoveUpRightIconinPricing.react-iconswithlucide-reacticons inMarketplaceTable.