Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 5, 2024

Before:
image

After:
image


PR-Codex overview

This PR focuses on updating the layout and styling of the supply-cards and page components in the NFT dashboard, enhancing responsiveness and visual hierarchy.

Detailed summary

  • Changed the layout of the supply-cards from a horizontal (flex-row) to a vertical (flex-col) arrangement.
  • Updated the heading in page.tsx from font-bold text-xl to font-semibold text-2xl tracking-tight.
  • Adjusted the layout of the page.tsx content to use a grid and modified spacing classes for better alignment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: f5b8230

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 9, 2024 10:32pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 9, 2024 10:32pm
wallet-ui ⬜️ Skipped (Inspect) Oct 9, 2024 10:32pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 5, 2024
@codecov
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (7c10343) to head (f5b8230).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4928   +/-   ##
=======================================
  Coverage   47.68%   47.68%           
=======================================
  Files        1058     1058           
  Lines       57290    57290           
  Branches     3942     3942           
=======================================
  Hits        27319    27319           
  Misses      29280    29280           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7c10343
packages 43.46% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 428 ms (-8.37% 🔽) 1.3 s
thirdweb (cjs) 101.66 KB (0%) 2.1 s (0%) 842 ms (-1.46% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 29 ms (-35.44% 🔽) 126 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 58 ms (+306.39% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 167 ms (+57.14% 🔺) 512 ms

@kien-ngo kien-ngo changed the title [Dashboard] Fix nimor layer issues [Dashboard] Fix minor layer issues Oct 5, 2024
Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title and All buttons centered looks weird.

Lets keep the title left aligned and all buttons in 2x2 grid - 2 buttons on row1, 2 buttons on row2

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address comments

@kien-ngo kien-ngo force-pushed the kien/fix-minor-ui-oct-5 branch from 5493655 to bebfc15 Compare October 9, 2024 04:28
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 04:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 04:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 04:28 Inactive
Copy link
Contributor Author

kien-ngo commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 22:09 Inactive
@MananTank MananTank force-pushed the kien/fix-minor-ui-oct-5 branch from 942cc38 to 3fc287d Compare October 9, 2024 22:11
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 22:11 Inactive
Copy link
Member

tweaked it a bit to:

image.png

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Merge activity

Before:
![image](https://github.com/user-attachments/assets/5429077d-24ee-4641-8025-137a67ab187d)

After:
![image](https://github.com/user-attachments/assets/72784965-1708-48a9-b614-970697ad40b9)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the layout and styling of components in the `supply-cards.tsx` and `page.tsx` files to enhance the visual structure and responsiveness of the dashboard interface.

### Detailed summary
- In `supply-cards.tsx`, changed the layout from a row (`flex-row`) to a column (`flex-col`) for better alignment.
- In `page.tsx`, modified the layout to use `flex-col` with additional styling adjustments, including:
  - Updated heading class from `font-bold text-xl` to `font-semibold text-2xl tracking-tight`.
  - Adjusted the container to use a grid layout for better responsiveness.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/fix-minor-ui-oct-5 branch from 3fc287d to f5b8230 Compare October 9, 2024 22:27
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 22:27 Inactive
@graphite-app graphite-app bot merged commit f5b8230 into main Oct 9, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/fix-minor-ui-oct-5 branch October 9, 2024 22:33
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 9, 2024 22:33 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 9, 2024 22:33 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 9, 2024 22:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants